Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore "non-existing" errors when getDirectorySize calculates the size #28276

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

wxiaoguang
Copy link
Contributor

The git command may operate the git directory (add/remove) files in any time.

So when the code iterates the directory, some files may disappear during the "walk". All "IsNotExist" errors should be ignored.

Fix #26765

@wxiaoguang wxiaoguang added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 labels Nov 29, 2023
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Nov 29, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 29, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 29, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 29, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 29, 2023
@wxiaoguang wxiaoguang merged commit b348424 into go-gitea:main Nov 29, 2023
25 checks passed
@wxiaoguang wxiaoguang deleted the fix-repo-size-lstat branch November 29, 2023 05:09
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.21. @wxiaoguang, please send one manually. 🍵

go run ./contrib/backport 28276
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Nov 29, 2023
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Nov 29, 2023
go-gitea#28276)

The git command may operate the git directory (add/remove) files in any
time.

So when the code iterates the directory, some files may disappear during
the "walk". All "IsNotExist" errors should be ignored.
@wxiaoguang wxiaoguang added the backport/done All backports for this PR have been created label Nov 29, 2023
wxiaoguang added a commit that referenced this pull request Nov 30, 2023
#28276) (#28285)

Backport #28276

The git command may operate the git directory (add/remove) files in any
time.

So when the code iterates the directory, some files may disappear during
the "walk". All "IsNotExist" errors should be ignored.
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 1, 2023
* giteaofficial/main:
  Read `previous` info from git blame (go-gitea#28306)
  Add missing variable in tag list (go-gitea#28305)
  Make pushUpdate error verbose (go-gitea#28263)
  Meilisearch: require all query terms to be matched (go-gitea#28293)
  Ignore "non-existing" errors when getDirectorySize calculates the size (go-gitea#28276)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
go-gitea#28276)

The git command may operate the git directory (add/remove) files in any
time.

So when the code iterates the directory, some files may disappear during
the "walk". All "IsNotExist" errors should be ignored.

Fix go-gitea#26765
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
go-gitea#28276)

The git command may operate the git directory (add/remove) files in any
time.

So when the code iterates the directory, some files may disappear during
the "walk". All "IsNotExist" errors should be ignored.

Fix go-gitea#26765
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error "failed to update size for mirror repository: updateSize: lstat [...] no such file or directory"
4 participants